Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32 ADC INTERNAL CHANNEL reset after read #10143

Merged
merged 1 commit into from
Apr 2, 2019
Merged

STM32 ADC INTERNAL CHANNEL reset after read #10143

merged 1 commit into from
Apr 2, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

Hi

This is replacing #9560, not only for STM32L0 but for all STM32 families.
Internal channels use is enabling ADC "internal path" which needs to be disabled after measurement.

@RobVlaar please have a look on this new correction

@LMESTM please take it into account for #9814

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from screamerbg and a team March 18, 2019 16:01
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

not only for STM32L0 but for all STM32 families.

🎉

@LMESTM
Copy link
Contributor

LMESTM commented Mar 19, 2019

@jeromecoutant - I think #9814 is not far from being merged, I'd prefer this PR to be updated once STM32WB is merged.

@LMESTM
Copy link
Contributor

LMESTM commented Mar 29, 2019

@jeromecoutant - I think #9814 is not far from being merged, I'd prefer this PR to be updated once STM32WB is merged.

@cmonr @jeromecoutant Actually #9814 is being blocked.
Please proceed with the review / merge of this PR and I will apply the same in #9814 or after it ...

@LMESTM
Copy link
Contributor

LMESTM commented Mar 29, 2019

I have approved but actually one comment:
please add below sentence to the commit message:
"Internal channels use is enabling ADC "internal path" which needs to be disabled after measurement."

@jeromecoutant
STM32 ADC INTERNAL CHANNEL reset after read
ec00ea5 
Internal channels use is enabling ADC "internal path"
which needs to be disabled after measurement
@jeromecoutant
Copy link
Collaborator Author

Rebase and commit update done

LMESTM added a commit to LMESTM/mbed that referenced this pull request Mar 29, 2019
@LMESTM
STM32WB: ADC INTERNAL CHANNEL reset after read
b0f4815 
Internal channels use is enabling ADC "internal path" which needs
to be disabled after measurement.

Same applied here for WB family as was done for others in ARMmbed#10143.
@jeromecoutant
Copy link
Collaborator Author

@cmonr
Could you remove the "preceding PR" label and start the CI ?
Thx

@cmonr
Copy link
Contributor

cmonr commented Apr 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 2a694cf into ARMmbed:master Apr 2, 2019
@jeromecoutant jeromecoutant deleted the PR_ADC_RESETINTERNAL branch April 2, 2019 12:56
0xc0170 pushed a commit that referenced this pull request Apr 5, 2019
@LMESTM @0xc0170
STM32WB: ADC INTERNAL CHANNEL reset after read
c5b277f 
Internal channels use is enabling ADC "internal path" which needs
to be disabled after measurement.

Same applied here for WB family as was done for others in #10143.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@LMESTM LMESTM LMESTM approved these changes

@screamerbg screamerbg Awaiting requested review from screamerbg

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeromecoutant @ciarmcom @cmonr @LMESTM @mbed-ci @0xc0170